chore(merge-flow): use go-version stable instead of pinning to go.mod - #162
Open
machine424 wants to merge 1 commit into
Open
chore(merge-flow): use go-version stable instead of pinning to go.mod#162machine424 wants to merge 1 commit into
machine424 wants to merge 1 commit into
Conversation
go.mod declares a minimum Go version, but workspace sub-modules or their deps may require a newer patch. Upstream CI typically runs a newer Go (e.g. 1.27) hiding such inconsistencies, so pinning to go.mod can break "go mod tidy + vendor" here with errors like "module X requires go >= 1.25.10 (running go 1.25.8)". Use go-version: stable and let downstream repos CIs decide whether they are ready. Ref: https://github.com/rhobs/syncbot/actions/runs/32792332062/job/97636246281
machine424
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go.mod declares a minimum Go version, but workspace sub-modules or their deps may require a newer patch. Upstream CI typically runs a newer Go (e.g. 1.27) hiding such inconsistencies, so pinning to go.mod can break
go mod tidy + vendorhere with errors likemodule X requires go >= 1.25.10 (running go 1.25.8).Use
go-version: stableand let downstream repos CIs decide whether they are ready.Ref: https://github.com/rhobs/syncbot/actions/runs/32792332062/job/97636246281