Skip to content

COO-2380: networkpolicy for operands - #1306

Open
jan--f wants to merge 3 commits into
rhobs:mainfrom
jan--f:feature/coo-2380-networkpolicy-foundation
Open

jan--f wants to merge 3 commits into
rhobs:mainfrom
jan--f:feature/coo-2380-networkpolicy-foundation

Conversation

@jan--f

@jan--f jan--f commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Assisted-by: opencode (openai/gpt-5.3-codex)
Assisted-by: opencode (openai/gpt-5.6-terra)
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Assisted-by: opencode (openai/gpt-5.3-codex)
Assisted-by: opencode (openai/gpt-5.6-terra)
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Assisted-by: opencode (openai/gpt-5.6-terra)
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
@openshift-ci-robot

openshift-ci-robot commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

@jan--f: This pull request references COO-2380 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Oct 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: e8d8432f-cdb7-4e26-b53b-6979c6aef10a
📥 Commits

Reviewing files that changed from the base of the PR and between ba63098 and 7f1c12e.

📒 Files selected for processing: 12
  • pkg/controllers/monitoring/monitoring-stack/components.go
  • pkg/controllers/monitoring/monitoring-stack/controller.go
  • pkg/controllers/monitoring/monitoring-stack/networkpolicy_test.go
  • pkg/controllers/monitoring/thanos-querier/components.go
  • pkg/controllers/monitoring/thanos-querier/controller.go
  • pkg/controllers/monitoring/thanos-querier/networkpolicy_test.go
  • pkg/controllers/uiplugin/components.go
  • pkg/controllers/uiplugin/controller.go
  • pkg/controllers/uiplugin/network_policy.go
  • pkg/controllers/uiplugin/network_policy_test.go
  • test/e2e/monitoring_stack_controller_test.go
  • test/e2e/thanos_querier_controller_test.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

The PR adds NetworkPolicy reconciliation for Monitoring Stack, Thanos Querier, and UI plugin components. Monitoring Stack and Thanos Querier policies allow all ingress and egress. UI plugin policies define ingress peers and TCP ports for plugin backends and optional dependencies. The controllers watch owned NetworkPolicies for resource-version changes. Unit and end-to-end tests cover policy creation, reconciliation, and configuration.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Suggested reviewers: simonpasquier

Merge Risk: ⚪ Minimal · up to 7f1c1

The change adds NetworkPolicies for monitoring and UI plugin operands. No concrete merge-blocking defect was established. Owners may still want to confirm that the console namespace carries the expected policy-group label on supported OpenShift versions.

Pre-merge checks: Passed 3 · Failed 1 · Inconclusive 1

Failed Failed checks: 1 warning · 1 inconclusive

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 7.69% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 52 functions across 12 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check Inconclusive No pull request description was provided, so the changeset has no author-provided explanation. Add a concise description of the NetworkPolicy reconciliation changes and the affected components.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: adding NetworkPolicy support for operands.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants