Skip to content

fix(installer): an upgrade run by hand keeps starting with the session instead of uninstalling it first #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgdevment merged 1 commit into from
Oct 14, 2026
Merged

fix(installer): an upgrade run by hand keeps starting with the session instead of uninstalling it first #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/bundle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ jobs:
"keep the binaries out of the data folder"
want '!define MAINBINARYNAME "cp-gui"' \
"keep cp-gui.exe, the program the startup entry and the shortcuts already point at"
want '${OrIf} $R0 <> 0 StrCpy $R1 "$R1 /UPDATE"' \
"tell the old uninstaller it is an update, so an upgrade run by hand keeps the startup entry"
want '!define HOMENAME "CopyPaste"' \
"keep the folders, keys and startup entry it has always had under CopyPaste"
want '_is1" "UninstallString"' \
Expand Down
5 changes: 4 additions & 1 deletion app/src-tauri/installer.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,10 @@ Function PageLeaveReinstall
${Else}
ReadRegStr $4 SHCTX "${MANUPRODUCTKEY}" ""
ReadRegStr $R1 SHCTX "${UNINSTKEY}" "UninstallString"
${IfThen} $UpdateMode = 1 ${|} StrCpy $R1 "$R1 /UPDATE" ${|} ; append /UPDATE
${If} $UpdateMode = 1
${OrIf} $R0 <> 0
StrCpy $R1 "$R1 /UPDATE"
${EndIf}
${IfThen} $PassiveMode = 1 ${|} StrCpy $R1 "$R1 /P" ${|} ; append /P
StrCpy $R1 "$R1 _?=$4" ; append uninstall directory
ExecWait '$R1' $0
Expand Down
Loading