Skip to content

Use new WebAPI #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nojaf wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Use new WebAPI #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44e0f44
Update to ReScript 12
nojaf Dec 6, 2024
11a1a5c
Use WebAPI types in events
nojaf Dec 6, 2024
9945b34
fix webapi experimental version
Freddy03h Apr 17, 2026
c4a8284
delete bs files
Freddy03h Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 21 additions & 93 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,8 @@
"@rescript/runtime": ">=12.0.0",
"react": ">=19.2.0",
"react-dom": ">=19.2.0"
},
"dependencies": {
"@rescript/webapi": "0.1.0-experimental-61b1074"
}
}
10 changes: 8 additions & 2 deletions rescript.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
},
"sources": [
{
"dir": "src"
"dir": "src",
"subdirs": true
}
],
"package-specs": [
Expand All @@ -14,5 +15,10 @@
"in-source": true
}
],
"suffix": ".res.js"
"suffix": ".res.js",
"dependencies": [
"@rescript/webapi"
],
"dev-dependencies": [],
"compiler-flags": []
}
17 changes: 10 additions & 7 deletions src/ReactDOM.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@
calls and add the appropriate `require("react-dom")` in the file calling this `render` */

// Helper so that ReactDOM itself doesn't bring any runtime

open WebAPI

@val @return(nullable)
external querySelector: string => option<Dom.element> = "document.querySelector"
external querySelector: string => option<DOMAPI.element> = "document.querySelector"

module Client = {
module Root = {
Expand All @@ -19,10 +22,10 @@ module Client = {
}

@module("react-dom/client")
external createRoot: Dom.element => Root.t = "createRoot"
external createRoot: DOMAPI.element => Root.t = "createRoot"

@module("react-dom/client")
external hydrateRoot: (Dom.element, React.element) => Root.t = "hydrateRoot"
external hydrateRoot: (DOMAPI.element, React.element) => Root.t = "hydrateRoot"
}

// Very rudimentary form data bindings
Expand Down Expand Up @@ -72,18 +75,18 @@ module FormData = {
}

@module("react-dom")
external createPortal: (React.element, Dom.element) => React.element = "createPortal"
external createPortal: (React.element, DOMAPI.element) => React.element = "createPortal"

external domElementToObj: Dom.element => {..} = "%identity"
external domElementToObj: DOMAPI.element => {..} = "%identity"

type style = ReactDOMStyle.t

type domRef = JsxDOM.domRef

module Ref = {
type t = domRef
type currentDomRef = React.ref<nullable<Dom.element>>
type callbackDomRef = nullable<Dom.element> => option<unit => unit>
type currentDomRef = React.ref<nullable<DOMAPI.element>>
type callbackDomRef = nullable<DOMAPI.element> => option<unit => unit>

external domRef: currentDomRef => domRef = "%identity"
external callbackDomRef: callbackDomRef => domRef = "%identity"
Expand Down
Loading
Loading