[codex] rename overloaded constructors to from* names#255
Draft
jderochervlk wants to merge 22 commits intomainfrom
Draft
[codex] rename overloaded constructors to from* names#255jderochervlk wants to merge 22 commits intomainfrom
jderochervlk wants to merge 22 commits intomainfrom
Conversation
Port the surviving API cleanup from the final pre-alpha branch onto the monorepo split introduced in #249. This adds the missing concrete modules, translates the fetch/runtime/canvas/websocket/media surface cleanup into the package layout, and keeps the branch green with updated tests.
Drop scroll2/scrollTo2/scrollBy2 and keep the descriptive *XY overload names requested in review. Co-authored-by: Codex <codex@openai.com>
…with-commits-and-responses Address review feedback: rename constructors, unbox FormDataEntryValue, reuse MessageEvent types, simplify tests
…-webapi into codex/issue-236-constructor-from-names-carryover
jderochervlk
commented
Apr 20, 2026
Comment on lines
+89
to
+91
|
|
||
| @new | ||
| external fromString: (~init: string) => domMatrix = "DOMMatrix" |
Collaborator
Author
There was a problem hiding this comment.
If it's just a single type, it should never have the ~init and just take the direct argument.
Suggested change
| @new | |
| external fromString: (~init: string) => domMatrix = "DOMMatrix" | |
| @new | |
| external fromString: (init: string) => domMatrix = "DOMMatrix" |
Update DOMMatrix, DOMMatrixReadOnly, Path2D, and ReadableStream single-source constructor overloads to take direct unlabeled arguments. Refresh compile-coverage tests and contributor documentation to match the constructor naming convention.
jderochervlk
commented
Apr 20, 2026
Comment on lines
+8
to
+9
| Source shape: | ||
| - no source input; this constructor creates a fresh MDN [Path2D](https://developer.mozilla.org/docs/Web/API/Path2D). |
Collaborator
Author
There was a problem hiding this comment.
We don't need the source shape callout that this function takes no input, that is clear from the type signature.
jderochervlk
commented
Apr 20, 2026
Comment on lines
+25
to
+26
| Source shape: | ||
| - local [`Path2D.t`](#t) mapped to MDN [Path2D](https://developer.mozilla.org/docs/Web/API/Path2D). |
Collaborator
Author
There was a problem hiding this comment.
I don't think any of these Source shape blocks are needed, the type and description are good enough.
jderochervlk
commented
Apr 20, 2026
| /** | ||
| `fromPath2D(path2D)` | ||
|
|
||
| The Path2D() constructor creates a new Path2D object by copying another Path2D source. |
Collaborator
Author
There was a problem hiding this comment.
The first part with The Path2D() constructor Is too verbose and too javascripty. Just focus on the ReScript side and keep it simple. And use backticks are specific types and names. Also try and not use overly verbose things like Path2D object when just saying Path2D is clear enough.
Suggested change
| The Path2D() constructor creates a new Path2D object by copying another Path2D source. | |
| Creates a new `Path2D` by copying another `Path2D` source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from*source-type namesmake()sharedArrayBufferalias inVideoFrameValidation
npm run buildASTRO_TELEMETRY_DISABLED=1 npm run build:docsNotes
npm run format:checkstill reports pre-existing failures oncarryover/post-249-pre-alphafix: rename overloaded constructors to from names*
style: format Path2D on carryover branch
refactor: localize VideoFrame shared array buffer alias