Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7ba486ec4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "dependencies": { | ||
| "rescript-signals": "^3.1.0", | ||
| "xote": "^6.2.0" | ||
| "xote": "^7.1.0" |
There was a problem hiding this comment.
Restore the SSR template's direct signals dependency
When this template is scaffolded through pnpm, the CLI imports the lockfile and adds only rescript, so rescript-signals remains an xote-only transitive dependency rather than a root module. The template nevertheless lists it in rescript.json and directly calls Signal.* in Counter.res; with pnpm's default non-hoisted layout, pnpm run res:build cannot resolve that declared package. Keep rescript-signals as a direct package.json dependency (and lockfile root dependency).
AGENTS.md reference: AGENTS.md:L20-L20
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
xote already exposes the rescript-signals modules.
Update xote from 6.2 to 7.1 in templates. Update code examples with the
@xote.componentnotation.Previous syntax is 100% backwards compatible.