Auto unload on timeout - #506
Open
brycehenson wants to merge 10 commits into
Open
Conversation
added 2 commits
August 17, 2026 07:14
brycehenson
marked this pull request as ready for review
August 17, 2026 08:05
Owner
|
Nice work, careful timer handling. Two things:
|
Centralize request timeout accounting into ModelManager.hold(). Use it for generate_from_phonemes(). Remove MODEL_AUTO_UNLOAD_ENABLED. Replace it with MODEL_AUTO_UNLOAD_TIMEOUT_SECONDS=0 is the default/off state.
Author
|
Thanks, good points. Implemented 1 and 2. validation with unit tests:
Validation with integrations tests:
ps: Thank you for building and maintaining such a great tool ! |
added 2 commits
August 20, 2026 06:57
… config.py inline comment on allow_dev_unload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds unload after a period of inactivity.
request for feeback
Would you prefer a different flag name ?
TODO