Skip to content

Fix unreadable initial heading in the State overview demo in dark mode - #7681

Merged
FarhanAliRaza merged 6 commits into
mainfrom
ccr-921eda66-kjt8mt-state-overview-dark
Oct 27, 2026
Merged

FarhanAliRaza merged 6 commits into
mainfrom
ccr-921eda66-kjt8mt-state-overview-dark

Conversation

@FarhanAliRaza

@FarhanAliRaza FarhanAliRaza commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description

The State overview example cycles the "Welcome to Reflex!" heading through a list of colors starting at a hard-coded black, which is near-invisible on the dark theme card (DOC-F02 in the daily bug report, ~1.3:1 contrast). The list now starts from the theme foreground color var(--gray-12), so the initial state reads in both themes while the demo still shows the same click-to-cycle behavior.

https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ


Generated by Claude Code

View guided diff Turn on auto-fix

The example cycled from a hard-coded black, which is near-invisible on the
dark theme card. Start from the theme's foreground color instead.

Claude-Session: https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ
@FarhanAliRaza
FarhanAliRaza requested review from a team and Alek99 as code owners October 27, 2026 20:18
@FarhanAliRaza FarhanAliRaza added the documentation Improvements or additions to documentation label Oct 27, 2026 — with Claude

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge, with no outstanding actionable findings.

Summary

Changes the State overview demo’s starting color from black to var(--gray-12) so the heading follows the theme.

  • The State overview heading starts with a readable theme color.

Reviews (5) · Last reviewed commit: "Isolate the State overview test's state ..." · Reviewed by Greptile

Comment thread docs/state/overview.md

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread docs/app/tests/test_state_overview_demo.py Outdated
@codspeed

codspeed Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 7.81%

2 warnings

⚠️ 13 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 147 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_state_access[write_inherited] 238.7 ms 221.4 ms +7.81%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ccr-921eda66-kjt8mt-state-overview-dark (cc3338b) with main (2a2a4c1)

Open in CodSpeed

Keeps the demo's state class from colliding with the one
test_docgen_double_eval registers for the real page.

Claude-Session: https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ
@linear-code

linear-code Bot commented Oct 27, 2026

Copy link
Copy Markdown

ENG-13591

Copy link
Copy Markdown
Contributor Author

Validated in the docs app running locally on this branch. The "Welcome to Reflex!" heading is readable in dark mode:

State overview heading in dark mode


Generated by Claude Code

@FarhanAliRaza
FarhanAliRaza merged commit 04953bc into main Oct 27, 2026
168 checks passed
@FarhanAliRaza
FarhanAliRaza deleted the ccr-921eda66-kjt8mt-state-overview-dark branch October 27, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant