Fix 404 audio in the browser JavaScript sound demo by FarhanAliRaza · Pull Request #7675 · reflex-dev/reflex

FarhanAliRaza · 2026-10-27T20:17:38Z

Type of change

Bug fix (non-breaking change which fixes an issue)

Description

The inline-script sound demo on api-reference/browser-javascript hard-coded /vintage-button-sound-effect.mp3, but the docs site is mounted at /docs, so the request returned 404 and both play buttons were silent. The demo now resolves the file with rx.asset, which prepends the frontend path and also shows readers the supported way to reference an asset.

Rendering the page locally confirms the script now references /docs/vintage-button-sound-effect.mp3.

https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ

Generated by Claude Code

The demo hard-coded /vintage-button-sound-effect.mp3, but the docs site is mounted at /docs, so the file was never found and both play buttons were silent. Resolving the file with rx.asset prepends the frontend path and also shows readers the supported way to reference an asset. Claude-Session: https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ

cubic-dev-ai

No issues found across 2 files

_{View guided diff | Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-10-27T20:19:41Z

Confidence Score: 5/5

[Low impact] The PR appears safe to merge; no new actionable issues were found.

Summary

The sound demo now uses rx.asset so its audio URL includes the /docs prefix.

The browser JavaScript sound demo loads its audio from the docs path.

_{Reviews (4) · Last reviewed commit: "Isolate the sound demo test's state regi..." · Reviewed by Greptile}

Claude-Session: https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ

…rectory Claude-Session: https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ

codspeed · 2026-10-27T20:27:35Z

Merging this PR will improve performance by 5.1%

2 warnings

⚠️ 16 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 147 untouched benchmarks

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`test_state_access[write_inherited]`	238.7 ms	227.1 ms	+5.1%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing ccr-921eda66-kjt8mt-sound-demo (ba5fbd4) with main (2a2a4c1)}

Rendering the page under the real path registered the demo's state class first, so test_docgen_double_eval's re-evaluation of the same page failed with a duplicate substate. Claude-Session: https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ

cubic-dev-ai

All reported issues were addressed across 1 file (changes from recent commits).

_{Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic}

linear-code · 2026-10-27T20:32:51Z

ENG-13585

Render inside a RegistrationContext, as the tutorial tests do, so the demo's state class does not stay in the shared registries. Claude-Session: https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ

FarhanAliRaza · 2026-10-27T22:02:37Z

Validated in the docs app running locally on this branch. The demo's audio source is now /docs/vintage-button-sound-effect.mp3 and the file returns 200:

Generated by Claude Code

FarhanAliRaza requested review from a team and Alek99 as code owners October 27, 2026 20:17

FarhanAliRaza added the documentation Improvements or additions to documentation label Oct 27, 2026 — with Claude

cubic-dev-ai Bot reviewed Oct 27, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 27, 2026

View reviewed changes

Comment thread docs/api-reference/browser_javascript.md

FarhanAliRaza added 2 commits October 27, 2026 20:20

Add regression test for the sound demo asset path

1a4ea56

Claude-Session: https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ

Anchor the sound demo test to the test file instead of the working di…

ad6d168

…rectory Claude-Session: https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ

cubic-dev-ai Bot reviewed Oct 27, 2026

View reviewed changes

Comment thread docs/app/tests/test_browser_javascript_demo.py

Isolate the sound demo test's state registration

ba5fbd4

Render inside a RegistrationContext, as the tutorial tests do, so the demo's state class does not stay in the shared registries. Claude-Session: https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ

FarhanAliRaza mentioned this pull request Oct 27, 2026

Fix dark-mode contrast in the layout component demos #7676

Merged

1 task done

FarhanAliRaza merged commit c458e33 into main Oct 27, 2026
168 checks passed

FarhanAliRaza deleted the ccr-921eda66-kjt8mt-sound-demo branch October 27, 2026 22:15

Navigation Menu

Repository navigation

Fix 404 audio in the browser JavaScript sound demo - #7675

Fix 404 audio in the browser JavaScript sound demo#7675
FarhanAliRaza merged 5 commits into
mainfrom
ccr-921eda66-kjt8mt-sound-demo

FarhanAliRaza commented Oct 27, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

greptile-apps Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

codspeed Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

linear-code Bot commented Oct 27, 2026

Uh oh!

FarhanAliRaza commented Oct 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

FarhanAliRaza commented Oct 27, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

codspeed Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 5.1%

Performance Changes

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

linear-code Bot commented Oct 27, 2026

Uh oh!

FarhanAliRaza commented Oct 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

FarhanAliRaza commented Oct 27, 2026 •

edited by cubic-dev-ai Bot

Loading

greptile-apps Bot commented Oct 27, 2026 •

edited

Loading

codspeed Bot commented Oct 27, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading