Repository navigation
Fix blank digit-x-digit icons in dynamic rx.icon and lighten the icon gallery - #7674
Conversation
… gallery Var-tagged icons were passed to Lucide's DynamicIcon with the snake_case hyphenation (grid-2x-2-check), which Lucide does not know, so the five grid_2x_2*/grid_3x_3 entries rendered blank in the docs icon gallery. The dynamic name now drops the hyphen inside digit-x-digit names. The gallery also wrapped each of ~1,600 icons in a Radix tooltip; a native title attribute gives the same hover text at a fraction of the React tree. Claude-Session: https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryFixes dynamic icon names such as
The only change since the previous review is the stub hash update. No actionable new issues or repository-rule violations were found. No previous review threads were supplied. Reviews (2) · Last reviewed commit: "Update pyi hash for the lucide icon stub" · Reviewed by Greptile |
Merging this PR will improve performance by 4.93%2 warnings
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes |
|
Validated in the docs app running locally on this branch. The gallery filtered to "grid" now renders every No Generated by Claude Code |
Type of change
Description
On the icon gallery,
grid_2x_2,grid_2x_2_check,grid_2x_2_plus,grid_2x_2_xandgrid_3x_3rendered blank with "Lucide DynamicIcon not found" errors. Var-tagged icons were handed to Lucide'sDynamicIconwith the snake_case hyphenation (grid-2x-2-check), which Lucide does not know. The dynamic name now also drops the hyphen inside digit-x-digit names, matching the deep-import file names already verified inLUCIDE_ICON_FILENAME_OVERRIDE.The gallery also wrapped each of ~1,600 icons in a Radix tooltip portal, which is a large part of why the page is the slowest in the docs. A native
titleattribute gives the same hover text at a fraction of the React tree.Tests
LUCIDE_ICON_LIST.uv run pytest tests/units/components/lucide, ruff and pyright pass.https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ
Generated by Claude Code