Skip to content

Fix blank digit-x-digit icons in dynamic rx.icon and lighten the icon gallery - #7674

Merged
FarhanAliRaza merged 2 commits into
mainfrom
ccr-921eda66-kjt8mt-icon-gallery
Oct 27, 2026
Merged

FarhanAliRaza merged 2 commits into
mainfrom
ccr-921eda66-kjt8mt-icon-gallery

Conversation

@FarhanAliRaza

@FarhanAliRaza FarhanAliRaza commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description

On the icon gallery, grid_2x_2, grid_2x_2_check, grid_2x_2_plus, grid_2x_2_x and grid_3x_3 rendered blank with "Lucide DynamicIcon not found" errors. Var-tagged icons were handed to Lucide's DynamicIcon with the snake_case hyphenation (grid-2x-2-check), which Lucide does not know. The dynamic name now also drops the hyphen inside digit-x-digit names, matching the deep-import file names already verified in LUCIDE_ICON_FILENAME_OVERRIDE.

The gallery also wrapped each of ~1,600 icons in a Radix tooltip portal, which is a large part of why the page is the slowest in the docs. A native title attribute gives the same hover text at a fraction of the React tree.

Tests

  • New unit tests cover the emitted JS expression and check that the runtime conversion agrees with the verified per-icon file name for every entry in LUCIDE_ICON_LIST.
  • uv run pytest tests/units/components/lucide, ruff and pyright pass.

https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ


Generated by Claude Code

View guided diff Turn on auto-fix

… gallery

Var-tagged icons were passed to Lucide's DynamicIcon with the snake_case
hyphenation (grid-2x-2-check), which Lucide does not know, so the five
grid_2x_2*/grid_3x_3 entries rendered blank in the docs icon gallery.
The dynamic name now drops the hyphen inside digit-x-digit names.

The gallery also wrapped each of ~1,600 icons in a Radix tooltip; a
native title attribute gives the same hover text at a fraction of the
React tree.

Claude-Session: https://claude.ai/code/session_01LwJUCUDZhZY71q8Azr37BQ
@FarhanAliRaza
FarhanAliRaza requested review from a team and Alek99 as code owners October 27, 2026 20:17
@FarhanAliRaza FarhanAliRaza added the documentation Improvements or additions to documentation label Oct 27, 2026 — with Claude

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

Fixes dynamic icon names such as grid_2x_2 and reduces the icon gallery’s component count.

  • Var-tagged icons now match Lucide’s digit-x-digit names.
  • The icon gallery shows names without a tooltip wrapper for each icon.

The only change since the previous review is the stub hash update. No actionable new issues or repository-rule violations were found. No previous review threads were supplied.

Reviews (2) · Last reviewed commit: "Update pyi hash for the lucide icon stub" · Reviewed by Greptile

@codspeed

codspeed Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 4.93%

2 warnings

⚠️ 19 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 147 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_state_access[write_inherited] 238.7 ms 227.5 ms +4.93%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ccr-921eda66-kjt8mt-icon-gallery (684600b) with main (2a2a4c1)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (16ca72d) during the generation of this report, so 2a2a4c1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@linear-code

linear-code Bot commented Oct 27, 2026

Copy link
Copy Markdown

ENG-13584

Copy link
Copy Markdown
Contributor Author

Validated in the docs app running locally on this branch. The gallery filtered to "grid" now renders every grid_* icon, including the five digit-x-digit names that were blank before:

Icon gallery grid icons

No DynamicIcon not found console errors on the page, and no Radix tooltip portals are mounted.


Generated by Claude Code

@FarhanAliRaza
FarhanAliRaza merged commit 17370c2 into main Oct 27, 2026
169 checks passed
@FarhanAliRaza
FarhanAliRaza deleted the ccr-921eda66-kjt8mt-icon-gallery branch October 27, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants