Skip to content

ENG-13482: our images and HTTP clients trust TLS certificates forged with eMudhra's crackable CA keys #7627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Darksinian wants to merge 1 commit into from
Closed

ENG-13482: our images and HTTP clients trust TLS certificates forged with eMudhra's crackable CA keys #7627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/legacy/reflex-0.8.23/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,8 @@ reflex-components-recharts = false
reflex-components-sonner = false
reflex-enterprise = false
reflex-hosting-cli = false
# 2026.10.19 drops the emSign ECC Root CA - G3 root, whose intermediates have crackable keys.
certifi = false

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Require the fixed certifi version in published metadata

This setting only changes uv's local lockfile resolution and is not included in the published Reflex wheel metadata. When a user upgrades Reflex in an environment that already has an older certifi, the unbounded transitive requirement from httpx remains satisfied, so pip can leave the vulnerable CA bundle installed and the stated TLS fix never reaches that user. Add a certifi >=2026.10.19 runtime dependency (or an equivalent published constraint), rather than only exempting certifi from exclude-newer.

Useful? React with 👍 / 👎.

@cubic-dev-ai cubic-dev-ai Bot Oct 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: certifi = false only bypasses uv’s resolver cutoff; it does not add a runtime requirement to published Reflex metadata. Pip installations can therefore retain vulnerable certifi versions despite the updated lock. Add certifi >=2026.10.19 to [project].dependencies, while retaining this override for lock resolution.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At pyproject.toml, line 563:

<comment>`certifi = false` only bypasses uv’s resolver cutoff; it does not add a runtime requirement to published Reflex metadata. Pip installations can therefore retain vulnerable certifi versions despite the updated lock. Add `certifi >=2026.10.19` to `[project].dependencies`, while retaining this override for lock resolution.</comment>

<file context>
@@ -559,6 +559,8 @@ reflex-components-recharts = false
 reflex-enterprise = false
 reflex-hosting-cli = false
+# 2026.10.19 drops the emSign ECC Root CA - G3 root, whose intermediates have crackable keys.
+certifi = false
 
 [tool.uv.sources]
</file context>


[tool.uv.sources]
hatch-reflex-pyi.workspace = true
Expand Down
7 changes: 4 additions & 3 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading