[harsh21234i]

Fixes #7426, where calling a local client-state setter from a sibling component could raise a ReferenceError and leave the displayed value unchanged.

The compiler now detects when local client state is shared across components and keeps those components in a compatible React scope. Added a compiler regression test and a Playwright test that verifies the sibling setter updates the rendered value. Included changelog entries for both affected packages.

Testing: Targeted unit and Playwright tests, Ruff, Pyright, and git diff --check pass locally.

[cubic-dev-ai]

All reported issues were addressed across 7 files

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[greptile-apps]

Confidence Score: 4/5

[Medium impact] The change reaches page compilation for local client-state components.

The PR still needs the previously reported fix for local state introduced by add_style() before merging.

Findings

1.  Default styles stop updating ▶

Summary

The PR keeps sibling readers and setters of page-local client state in the same React scope.

• Sibling components share one React scope for page-local client state.

_{Reviews (17) · Last reviewed commit: "perf: reduce shared scope collection ove..." · Reviewed by Greptile}

[codspeed]

Merging this PR will degrade performance by 4.56%

2 warnings

⚠️ 16 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

❌ 4 regressed benchmarks
✅ 144 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
❌	test_compile_all_artifacts[_complicated_page]	131.2 ms	139.7 ms	-6.06%
❌	test_compile_page[_complicated_page]	194.9 ms	203.2 ms	-4.1%
❌	test_compile_all_artifacts[_stateful_page]	38.1 ms	39.7 ms	-4.05%
❌	test_compile_page_full_context[_complicated_page]	211.2 ms	220 ms	-4.01%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing harsh21234i:fix/7426-local-client-state-sibling (1211cbf) with main (17370c2)}

[cubic-dev-ai]

All reported issues were addressed across 4 files (changes from recent commits).

<sub>Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic</sub>

[cubic-dev-ai]

All reported issues were addressed across 1 file (changes from recent commits).

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

View guided diff | Re-trigger cubic</sub>

[masenf]

i'm not too keen on patching memo plugin so deeply to support the old experimental client_state.

the new client state already uses scoped access on the javascript side and just works transparently without all this compiler machinery.

[cubic-dev-ai]

All reported issues were addressed across 4 files (changes from recent commits).

<sub>Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic</sub>

[harsh21234i]

Thanks, I understand the concern. I’ve simplified the prepass based on the review feedback, but this still adds compiler logic for the legacy experimental API. Since the newer client-state API already handles scoped access, would you prefer we keep a compatibility fix for this existing behavior, or close/defer this issue and direct users to the newer API?

[greptile-apps]

Default styles stop updating

Local state added by add_style() is missing from this scan. For example, subclass AutoScroll, return {"color": local.value} from add_style(), and place it beside a local.value reader and setter. The root scan runs before the child's default style is applied and only accounts for App.style. The child can then get its own memo component and state, so clicking the outside setter leaves its color unchanged.

Include default-style state users before computing the shared-scope decisions.