ci: fix release-drafter Maintenance category key#3358
Open
nkaradzhov wants to merge 2 commits into
Open
Conversation
The 'should move listeners when PubSub node disconnects from the cluster' test reassigns all 8192 slots one-by-one and then polls both nodes for cluster_state:ok. On slow CI runners that work can exceed mocha's default 2000ms timeout, causing intermittent "Timeout of 2000ms exceeded" failures across many PRs. testWithCluster ran the it() at the default timeout with no way to override it (only the before hook set 30000ms). Add an optional testTimeout to the shared CommonTestOptions, apply it in testWithCluster's it() when set, and raise this test's timeout to 30000ms. The guard means all other cluster tests are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Maintenance category in all module release-drafter configs used the
singular `label:` key with a list of values. release-drafter's schema
expects `label` to be a single string and `labels` to be the array form,
so config parsing failed Zod validation:
categories[3].label: expected string, invalid_type
Rename `label:` to `labels:` in bloom, entraid, json, search, and
time-series configs so the release draft workflow parses again.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
update_release_draftworkflow fails onmasterbecause every module release-drafter config uses the singularlabel:key with a list of values in the Maintenance category. release-drafter's schema expectslabelto be a single string andlabelsto be the array form, so config parsing fails Zod validation:(failing run)
Fix
Rename
label:→labels:in the Maintenance category of all five configs (bloom, entraid, json, search, time-series). The other three categories in each file already correctly uselabels:.🤖 Generated with Claude Code
Note
Low Risk
CI/config and test-harness timing only; no runtime library or security behavior changes.
Overview
Fixes
update_release_draftfailures by changing the Maintenance category in all five module release-drafter configs (bloom,entraid,json,search,time-series) fromlabel:(invalid with a list) tolabels:, matching release-drafter’s schema and the other categories in those files.Adds optional
testTimeouton shared cluster test options intest-utilsand applies it insidetestWithCluster. The cluster PubSub test that reassigns thousands of slots and waits forcluster_state:oknow setstestTimeout: 30000so it does not hit Mocha’s default 2s limit on slow CI.Reviewed by Cursor Bugbot for commit 2ee6f55. Bugbot is set up for automated code reviews on this repo. Configure here.