Skip to content

fix: patch core-components SignInPage provider persistence - #5632

Open
JessicaJHee wants to merge 2 commits into
redhat-developer:release-2.1from
JessicaJHee:patch-signinpage-logout-bug
Open

JessicaJHee wants to merge 2 commits into
redhat-developer:release-2.1from
JessicaJHee:patch-signinpage-logout-bug

Conversation

@JessicaJHee

@JessicaJHee JessicaJHee commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Description

Yarn patch @backstage/core-components@0.18.14 so SignInPage does not clear the selected provider from localStorage on logout/cancel (and memoizes provider setup).

Which issue(s) does this PR fix

PR acceptance criteria

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Sign in, sign out, confirm the previous provider is still selected without re-picking.

Made with Cursor

Apply a yarn patch on @backstage/core-components@0.18.14 so logout/cancel
no longer clears the selected sign-in provider from localStorage.

Co-authored-by: Cursor <cursoragent@cursor.com>
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.40%. Comparing base (c0eefe4) to head (c39587d).

Additional details and impacted files
@@             Coverage Diff              @@
##           release-2.1    #5632   +/-   ##
============================================
  Coverage        72.40%   72.40%           
============================================
  Files               68       68           
  Lines              790      790           
  Branches           113      113           
============================================
  Hits               572      572           
  Misses             217      217           
  Partials             1        1           
Flag Coverage Δ
rhdh 72.40% <ø> (ø)
Components Coverage Δ
Backend plugins 100.00% <ø> (ø)
Backend app 78.94% <ø> (ø)
Frontend app 57.43% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0eefe4...c39587d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

Drop unrelated dist diffs so the yarn patch only covers the
provider-persistence fix.

Co-authored-by: Cursor <cursoragent@cursor.com>
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@openshift-ci

openshift-ci Bot commented Oct 8, 2026

Copy link
Copy Markdown

@JessicaJHee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm c39587d link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant