chore(e2e): retire obsolete OFS fixtures

[hopehadfield]

Summary

• Retire the OFS-only application-provider and application-listener Playwright specs and their provider page fixture.
• Remove the legacy sidebar adapter and dual-adapter selection; keep the RHDH sidebar adapter for navigation.
• Update local E2E harness references and the historical migration matrix to reflect the retired tests. NFS root wrapper/element capabilities remain, but there is no direct E2E replacement for the old multi-provider or navigation-listener fixtures.

Verification

• e2e-tests/node_modules/.bin/vitest run — 101 passed
• e2e-tests/node_modules/.bin/oxlint . — passed
• e2e-tests/node_modules/.bin/oxfmt --check . — passed
• e2e-tests/node_modules/.bin/tsc --noEmit -p tsconfig.json — passed
• e2e-tests/node_modules/.bin/playwright test --list — passed
• git diff --check — passed
• Live Playwright suites not run: local dynamic-plugins-root is missing the catalog-index plugins.

RHIDP-17025

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[rhdh-qodo-merge]

PR Summary by Qodo

Retire obsolete OFS E2E fixtures and legacy sidebar navigation

🧪 Tests 📝 Documentation ⚙️ Configuration changes 🕐 20-40 Minutes

AI Description

• Remove skipped OFS-only provider and listener specs and their unused page fixture.
• Route sidebar navigation exclusively through the RHDH adapter, removing legacy detection and
 fallback code.
• Clarify local harness guidance and historical test counts without claiming replacement coverage.

Diagram

graph TD
  Specs["Remaining specs"] --> Navigation["Navigation helper"] --> Adapter["RHDH adapter"] --> App["NFS app"]
  Harness["Local harness"] --> App

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Replace fixtures with NFS-native test plugins

• ➕ Could restore direct multi-provider and navigation-listener E2E coverage.
• ➖ Requires new NFS extensions and exports; existing OCI fixtures expose only the former app entry point.

Recommendation: Retire the unusable fixtures and legacy navigation path now. If direct provider or listener coverage remains important, add NFS-native fixtures in a separate effort rather than treating existing root blueprints or unrelated tests as replacements.

Files changed (5) +37 / -120

Refactor (1) +4 / -93

navigation.tsUse the RHDH sidebar adapter directly +4/-93

Use the RHDH sidebar adapter directly

• Removes legacy sidebar imports, runtime detection, cached adapter selection, and wrapper functions. Shared sidebar actions now call the RHDH adapter directly.

e2e-tests/playwright/utils/ui-helper/navigation.ts

Documentation (2) +32 / -22

layer-migration-matrix.mdMark the provider and listener inventory entries as retired +17/-15

Mark the provider and listener inventory entries as retired

• Adds historical context, removes the two retired specs from the migration matrix, and adjusts the remaining L3 count and related planning text. It warns that historical suite totals are not current counts.

docs/e2e-tests/layer-migration-matrix.md

local-e2e-harness.mdExplain why the OFS fixtures have no direct NFS replacement +15/-7

Explain why the OFS fixtures have no direct NFS replacement

• Documents the retired specs and provider page fixture, distinguishes available NFS root blueprints from the missing legacy mount points, and clarifies that existing tests do not replace the old fixture checks.

docs/e2e-tests/local-e2e-harness.md

Other (2) +1 / -5

dynamic-plugins.yamlRemove stale comments about excluded OCI fixture plugins +0/-3

Remove stale comments about excluded OCI fixture plugins

• Removes comments describing the retired provider and listener plugins as prospective local harness dependencies.

e2e-tests/local-harness/dynamic-plugins.yaml

playwright.local.config.tsRemove obsolete dual-sidebar guidance from the local harness +1/-2

Remove obsolete dual-sidebar guidance from the local harness

• Simplifies the harness comment so it no longer refers to legacy sidebar selection or its removed environment override. The test allowlist remains unchanged.

e2e-tests/playwright.local.config.ts

[rhdh-qodo-merge]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can keep summaries lean with Findings visible per group, which tucks the rest behind a View link

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[rhdh-qodo-merge]

Important

The /generate_labels command by Qodo is sunsetting on the 1st of October 2026 and will no longer be available. We recommend switching to the latest Qodo review capabilities. Learn more

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.19%. Comparing base (e51f3cf) to head (959da32).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5624      +/-   ##
==========================================
- Coverage   72.77%   66.19%   -6.59%     
==========================================
  Files          68       61       -7     
  Lines         786      633     -153     
  Branches      113       96      -17     
==========================================
- Hits          572      419     -153     
  Misses        213      213              
  Partials        1        1              

Flag	Coverage Δ
rhdh	66.19% <ø> (-6.59%)	⬇️

Components	Coverage Δ
Backend plugins	∅ <ø> (∅)
Backend app	78.94% <ø> (ø)
Frontend app	58.03% <ø> (ø)

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51f3cf...959da32. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Image was built and published successfully. It is available at:

• quay.io/rhdh-community/rhdh:pr-5624
• quay.io/rhdh-community/rhdh:pr-5624-a21fa89e

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Image was built and published successfully. It is available at:

• quay.io/rhdh-community/rhdh:pr-5624
• quay.io/rhdh-community/rhdh:pr-5624-959da326

[openshift-ci]

@hopehadfield: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ocp-helm	959da32	link	true	/test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.