Skip to content

chore: harden renovate config validator and pin renovate@44 - #5611

Merged
openshift-merge-bot[bot] merged 6 commits into
redhat-developer:mainfrom
kim-tsao:chore/harden-renovate-config-validator
Oct 8, 2026
Merged

openshift-merge-bot[bot] merged 6 commits into
redhat-developer:mainfrom
kim-tsao:chore/harden-renovate-config-validator

Conversation

@kim-tsao

@kim-tsao kim-tsao commented Oct 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Harden .github/workflows/renovate-checks.yaml similar to rhdh-plugins#3756: least-privilege permissions, persist-credentials: false, and GITHUB_COM_TOKEN for validation.
  • Pin the validator package to renovate@44 so the npx cache is forced to refresh on the new major (v44 was an accidental major with no real breaking changes).

Test plan

  • Confirm the Renovate Config Validator workflow runs on a PR that touches .github/renovate.json
  • Confirm npx --yes --package renovate@44 -- renovate-config-validator --strict .github/renovate.json succeeds locally or in CI
  • Confirm workflow permissions remain read-only for contents

Made with Cursor

Comment thread .github/workflows/renovate-checks.yaml Fixed
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.19%. Comparing base (e2f0f51) to head (6826560).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5611      +/-   ##
==========================================
- Coverage   72.77%   66.19%   -6.59%     
==========================================
  Files          68       61       -7     
  Lines         786      633     -153     
  Branches      113       96      -17     
==========================================
- Hits          572      419     -153     
  Misses        213      213              
  Partials        1        1              
Flag Coverage Δ
rhdh 66.19% <ø> (-6.59%) ⬇️
Components Coverage Δ
Backend plugins ∅ <ø> (∅)
Backend app 78.94% <ø> (ø)
Frontend app 58.03% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f0f51...6826560. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: failure.

kim-tsao and others added 6 commits October 8, 2026 13:09
Align the workflow with rhdh-plugins hardening and pin renovate to major 44 so the npx cache refreshes.

Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid npx (Sonar S6505) by using ghcr.io/renovatebot/renovate:44 instead of latest for intentional major pinning.

Co-authored-by: Cursor <cursoragent@cursor.com>
Lock ghcr.io/renovatebot/renovate to 44.145.1 via sha256 for reproducible CI.

Co-authored-by: Cursor <cursoragent@cursor.com>
Use tag@digest form and re-enable digest updates only for ghcr.io/renovatebot/renovate.

Co-authored-by: Cursor <cursoragent@cursor.com>
renovate-config-validator is offline-only and does not need a GitHub token.

Co-authored-by: Cursor <cursoragent@cursor.com>
Checkout failed with EACCES on /__w/_temp because the renovate image user cannot write runner state files. Match renovatebot's container options so the job runs as UID 1001.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kim-tsao
kim-tsao force-pushed the chore/harden-renovate-config-validator branch from e60f1f7 to 6826560 Compare October 8, 2026 17:10
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@Omar-AlJaljuli Omar-AlJaljuli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@openshift-merge-bot
openshift-merge-bot Bot merged commit e51f3cf into redhat-developer:main Oct 8, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants