Skip to content

fix(dex): fetching changes for mounting dex sa token as projected volume mount - #1305

Merged
svghadi merged 3 commits into
redhat-developer:v1.22from
anandf:pick_dex_sa_vol_mnt_change
Sep 22, 2026
Merged

svghadi merged 3 commits into
redhat-developer:v1.22from
anandf:pick_dex_sa_vol_mnt_change

Conversation

@anandf

@anandf anandf commented Sep 21, 2026

Copy link
Copy Markdown
Member

What type of PR is this?
/kind bug

What does this PR do / why we need it:
Dex server pod restarts the dex server process whenever the static clientSecret changes. This causes existing token verification to fail, as the signing tokens stored in memory gets deleted. To overcome this limitation, external storage options (kubernetes/etcd) was evaluated, though it solved the problem of loosing the dex data, it requires additional care and encryption mechanism to store the sensitive data securely.

Using projected tokens, helps in token rotation directly in the disk by the kubelet and by making an enhancement in dex to read these short-lived tokens directly from the file, helps to avoid the dex server process restarts. It also simplifies the current token rotation mechanism which requires the operator to continuosly look at the service account secrets for any expiry and use the TokenRequest API to generate the token stored in a kubernetes Secret object.

Have you updated the necessary documentation?
N/A

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes
https://redhat.atlassian.net/browse/GITOPS-10364
https://redhat.atlassian.net/browse/GITOPS-10429

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

…ume mount

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
@openshift-ci openshift-ci Bot added the kind/bug Something isn't working label Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 78806fac-8cb3-4905-b1b5-37fa986c1982

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@anandf
anandf requested a review from svghadi September 21, 2026 12:58

@akhilnittala akhilnittala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svghadi svghadi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm label Sep 22, 2026

@svghadi svghadi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Sep 22, 2026
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm label Sep 22, 2026
@svghadi

svghadi commented Sep 22, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Sep 22, 2026
@svghadi
svghadi merged commit 777fe67 into redhat-developer:v1.22 Sep 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved kind/bug Something isn't working lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants