Skip to content

chore: migrate deprecated patchesJson6902 to patches in kustomization - #1304

Open
olivergondza wants to merge 1 commit into
redhat-developer:masterfrom
olivergondza:drop-patchesJson6902
Open

olivergondza wants to merge 1 commit into
redhat-developer:masterfrom
olivergondza:drop-patchesJson6902

Conversation

@olivergondza

Copy link
Copy Markdown
Collaborator

argoproj-labs/argocd-operator#2359

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • [no] Documentation update is required by this PR.
  • [no] Documentation has been updated.

Which issue(s) this PR fixes:

Fixes N/A

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci

openshift-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown

@olivergondza: The label(s) kind/code-refactoring cannot be applied, because the repository doesn't have them.

Details

In response to this:

argoproj-labs/argocd-operator#2359

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • [no] Documentation update is required by this PR.
  • [no] Documentation has been updated.

Which issue(s) this PR fixes:

Fixes N/A

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 59f6fe95-53cb-4779-be37-7352343800ba

📥 Commits

Reviewing files that changed from the base of the PR and between 72e3e4b and 4e8e495.

📒 Files selected for processing (2)
  • config/manifests/kustomization.yaml
  • config/scorecard/kustomization.yaml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • argoproj-labs/argocd-operator (manual)

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated deployment configuration to use the current Kustomize patch syntax.
    • Refreshed related configuration markers for compatibility with modern Kustomize tooling.

Walkthrough

The Kustomize configurations replace patchesJson6902 with patches. The scorecard scaffold marker now references patches.

Changes

Kustomize configuration updates

Layer / File(s) Summary
Replace deprecated patch key
config/manifests/kustomization.yaml, config/scorecard/kustomization.yaml
The configurations use patches instead of patchesJson6902. The existing patch definitions remain unchanged. The scorecard scaffold marker now references patches.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the migration from deprecated patchesJson6902 to patches in Kustomization files.
Description check ✅ Passed The description identifies the related change and categorizes the work as code refactoring. It is related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign olivergondza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown

@olivergondza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-parallel 4e8e495 link false /test v4.14-kuttl-parallel
ci/prow/v4.19-kuttl-parallel 4e8e495 link true /test v4.19-kuttl-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@olivergondza

Copy link
Copy Markdown
Collaborator Author

/test v4.19-kuttl-parallel

@olivergondza

Copy link
Copy Markdown
Collaborator Author

/test v4.19-kuttl-sequential

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant