[samsonasik]

Ref #8812 (comment)

I tested rector/rector:2.8.0 on CodeIgniter4 project, and somehow got crash:

{"fatal_errors":["Unable to delete directory '/tmp/rector/77/0

it is working ok on 2.7.0. Step to reproduce:

git clone https://github.com/codeigniter4/CodeIgniter4.git
cd CodeIgniter4
composer require --dev rector/rector:2.8.0
vendor/bin/rector

Turbo makes the parallel workers compute a different config hash than the main process, so each run's workers wipe the shared cache concurrently and race each other.

This PR fix it /cc @SanderMuller

[samsonasik]

Fixed 🎉 /cc @SanderMuller

[samsonasik]

@TomasVotruba ready 👍

[TomasVotruba]

Nice work 👍

[TomasVotruba]

Also, can you add this as CI Workflow here? So we can catch it a bit earlier next time :)

it is working ok on 2.7.0. Step to reproduce:

[samsonasik]

I will try 👍

[SanderMuller]

Awesome @samsonasik !

[SanderMuller]

The workers still run the configuration check when they boot, and each of them can clear the shared cache. If the main process and the workers differ in some other way, the race comes back. I can open a small PR so that only the main process runs this check.

[TomasVotruba]

@SanderMuller That would be great 👍 Please cover via CI workflow with a standalone compiled Rector (rector/rector) run on some small project.

[SanderMuller]

@SanderMuller That would be great 👍 Please cover via CI workflow with a standalone compiled Rector (rector/rector) run on some small project.

Perfect, PR is up, adding CI workflow to it now