Repository navigation
Add failing test case for Attribute Closure crash - #8802
Merged
Merged
Conversation
samsonasik
changed the title
samsonasik
force-pushed
the
failing-test-closure
branch
from
October 24, 2026 08:33
e9c40fe to
eb75944
Compare
Member
Author
|
@TomasVotruba Running the test now got: ➜ rector-src git:(failing-test-closure) vendor/bin/phpunit rules-tests/Php55/Rector/String_/StringClassNameToClassConstantRector
PHPUnit 13.4.3 by Sebastian Bergmann and contributors.
Runtime: PHP 8.4.25
Configuration: /Users/samsonasik/www/rector-src/phpunit.xml
E............. 14 / 14 (100%)
Time: 00:00.323, Memory: 96.52 MB
There was 1 error:
1) Rector\Tests\Php55\Rector\String_\StringClassNameToClassConstantRector\StringClassNameToClassConstantRectorTest::test@/Users/samsonasik/www/rector-src/rules-tests/Php55/Rector/String_/StringClassNameToClassConstantRector/Fixture/attribute_on_closure_and_arrow_function.php.inc with data ('/Users/samsonasik/www/rector-...hp.inc')
Rector\Exception\ShouldNotHappenException: Node "PhpParser\Node\Expr\ClassConstFetch" with is missing scope required for scope refresh
/Users/samsonasik/www/rector-src/src/Application/ChangedNodeScopeRefresher.php:72
/Users/samsonasik/www/rector-src/src/Rector/RectorRunner.php:126 |
Member
|
Awesome 👍 Can you look into with without using scope here? |
Member
Author
|
The Scope is needed so |
Member
Author
|
@TomasVotruba I've fixed with set scope on attribute on closure and arrowfunction it is needed so ClassConstFetch under closure can be refreshed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TomasVotruba here failing test case you requested at #8788 (comment)
without the patch, it got error: