Repository navigation
[perf] Speed up ConvertStaticToSelfRector by deferring scope fetching until static member access is found - #8801
Open
alfredbez wants to merge 1 commit into
Conversation
alfredbez
force-pushed
the
fix/rector-perf-convert-static-to-self-lazy-scope
branch
from
October 24, 2026 01:03
107a197 to
f2c7ecb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ConvertStaticToSelfRector,ScopeFetcher::fetch($node)and$scope->getClassReflection()were called immediately upon entering everyClass_node. For classes containing nostatic::calls, property fetches, or constant fetches, resolving scope and reflection is unnecessary.Reproducer
Expected Behavior
ConvertStaticToSelfRectorshould inspect member fetches and filter out non-staticcalls or dynamic member references before fetching scope, resolving class reflection lazily only when an eligible static access is found.