Repository navigation
[perf] Speed up RemoveUnusedPrivateMethodRector with early data provider and class-string call checks and deduplicated scope resolution - #8800
Open
alfredbez wants to merge 1 commit into
Conversation
alfredbez
force-pushed
the
fix/rector-perf-remove-unused-private-method-guard
branch
from
October 23, 2026 23:38
407339b to
3cea0fa
Compare
Member
|
Reorder is behavior-neutral and the win looks real (name-list checks now gate Could you add a quick before/after number though? This is the only one of the three perf PRs touching the hot traversal path, yet it ships no bench. A small |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
RemoveUnusedPrivateMethodRector,IsClassMethodUsedAnalyzer::isClassMethodUsed()(which traverses the class AST) was invoked for private methods before checking whether the method is a PHPUnit data provider or target of a class-string static call (self::class::method()). In addition,ScopeFetcher::fetch($node)was called repeatedly on the sameClass_node for each private method.Reproducer
Expected Behavior
RemoveUnusedPrivateMethodRectorshould check known-used method name lists (dataProviderMethodNamesandclassStringCallMethodNames) before running AST usage analysis, and fetch the class scope lazily at most once per class node.