Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/Caching/Contract/CacheMetaExtensionInterface.php

This file was deleted.

12 changes: 0 additions & 12 deletions src/Config/RectorConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -473,18 +473,6 @@ public function cacheClass(string $cacheClass): void
Assert::isAOf($cacheClass, CacheStorageInterface::class);
}

/**
* @param class-string $cacheMetaExtensionClass
*/
#[Deprecated(message: <<<'TXT'
Niche mechanism, no longer applied. Let Rector handle cache on its own. If custom
invalidation is needed, handle it in CI in a more generic way, e.g. by clearing the cache directory.
TXT)]
public function cacheMetaExtension(string $cacheMetaExtensionClass): void
{
SimpleParameterProvider::addParameter(Option::CACHE_META_EXTENSIONS, $cacheMetaExtensionClass);
}

/**
* @see https://github.com/nikic/PHP-Parser/issues/723#issuecomment-712401963
*/
Expand Down
5 changes: 0 additions & 5 deletions src/Configuration/Option.php
Original file line number Diff line number Diff line change
Expand Up @@ -240,11 +240,6 @@ final class Option
*/
public const string SKIPPED_NON_RECTOR_CLASSES = 'skipped_non_rector_classes';

/**
* @internal For reporting deprecated cache meta extensions
*/
public const string CACHE_META_EXTENSIONS = 'cache_meta_extensions';

/**
* @internal For reporting deprecated withPhp53Sets() ... withPhp74Sets() methods
*/
Expand Down
1 change: 0 additions & 1 deletion src/Configuration/Parameter/SimpleParameterProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ final class SimpleParameterProvider
Option::DEPRECATED_ATTRIBUTES_SETS_ARGS,
Option::DEPRECATED_COMPOSER_BASED_ARGS,
Option::LEVEL_OVERFLOWS,
Option::CACHE_META_EXTENSIONS,
Option::COMPOSER_BOUND_RULE_CONFIGURATIONS,
Option::ROOT_STANDALONE_REGISTERED_RULES,
Option::SET_REGISTERED_RULES,
Expand Down
15 changes: 0 additions & 15 deletions src/Configuration/RectorConfigBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -796,21 +796,6 @@ public function withCache(
return $this;
}

/**
* @param class-string $cacheMetaExtensionClass
* @deprecated Niche mechanism, no longer applied. Let Rector handle cache on its own.
*/
#[Deprecated(message: <<<'TXT'
Niche mechanism, no longer applied. Let Rector handle cache on its own. If custom
invalidation is needed, handle it in CI in a more generic way, e.g. by clearing the cache directory.
TXT)]
public function withCacheMetaExtension(string $cacheMetaExtensionClass): self
{
SimpleParameterProvider::addParameter(Option::CACHE_META_EXTENSIONS, $cacheMetaExtensionClass);

return $this;
}

/**
* @param class-string<ConfigurableRectorInterface> $rectorClass
* @param mixed[] $configuration
Expand Down
1 change: 0 additions & 1 deletion src/Console/Command/ProcessCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
// 4. Deprecations reporter
$this->deprecatedRulesReporter->reportDeprecatedRules();
$this->deprecatedRulesReporter->reportDeprecatedSkippedRules();
$this->deprecatedRulesReporter->reportDeprecatedCacheMetaExtensions();
$this->deprecatedRulesReporter->reportDeprecatedPhpSetsMethods();
$this->deprecatedRulesReporter->reportDeprecatedAttributesSetsArgs();
$this->deprecatedRulesReporter->reportDeprecatedComposerBasedArgs();
Expand Down
1 change: 0 additions & 1 deletion src/Console/Command/ValidateConfigCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int

$issueCount += $this->deprecatedRulesReporter->reportDeprecatedRules();
$issueCount += $this->deprecatedRulesReporter->reportDeprecatedSkippedRules();
$issueCount += $this->deprecatedRulesReporter->reportDeprecatedCacheMetaExtensions();
$issueCount += $this->deprecatedRulesReporter->reportDeprecatedPhpSetsMethods();
$issueCount += $this->deprecatedRulesReporter->reportDeprecatedAttributesSetsArgs();
$issueCount += $this->deprecatedRulesReporter->reportDeprecatedComposerBasedArgs();
Expand Down
17 changes: 0 additions & 17 deletions src/Reporting/DeprecatedRulesReporter.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,23 +57,6 @@ public function reportDeprecatedSkippedRules(): int
return $reportedCount;
}

public function reportDeprecatedCacheMetaExtensions(): int
{
/** @var string[] $cacheMetaExtensions */
$cacheMetaExtensions = SimpleParameterProvider::provideArrayParameter(Option::CACHE_META_EXTENSIONS);

$reportedCount = 0;
foreach ($cacheMetaExtensions as $cacheMetumExtension) {
$this->symfonyStyle->warning(sprintf(
'Cache meta extension "%s" is deprecated and no longer applied. It is a niche mechanism, let Rector handle cache on its own. If custom invalidation is needed, handle it in CI in a more generic way, e.g. by clearing the cache directory.',
$cacheMetumExtension
));
++$reportedCount;
}

return $reportedCount;
}

public function reportDeprecatedPhpSetsMethods(): int
{
/** @var string[] $deprecatedPhpSetsMethods */
Expand Down
1 change: 0 additions & 1 deletion tests/Console/Command/ValidateConfigCommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ protected function setUp(): void
Option::SKIPPED_NON_RECTOR_CLASSES,
Option::SKIPPED_RECTOR_RULES,
Option::SKIPPED_START_WITH_SHORT_OPEN_TAG_FILES,
Option::CACHE_META_EXTENSIONS,
Option::DEPRECATED_PHP_SETS_METHODS,
Option::DEPRECATED_ATTRIBUTES_SETS_ARGS,
Option::DEPRECATED_COMPOSER_BASED_ARGS,
Expand Down
Loading