[alfredbez]

In ArrayToFirstClassCallableRector, refactor() fetched the node's scope via ScopeFetcher::fetch($node) for every array before verifying that the array contains exactly two items, and before checking whether the array is a class constant value, default property value, parameter default, or unpacked argument. For non-callable arrays, scope resolution was performed unnecessarily.

Reproducer

class Subject
{
    public const DEFAULT_ITEMS = ['a', 'b', 'c'];

    public function run(): void
    {
        $single = ['item'];
        $triple = [1, 2, 3];
    }
}

Expected Behavior

ArrayToFirstClassCallableRector should verify that the array contains exactly two items and check attribute guards before calling ScopeFetcher::fetch($node). Non-callable arrays should be rejected early without resolving scope.

[TomasVotruba]

Thanks 👍