Repository navigation
Conversation
alfredbez
force-pushed
the
fix/rector-perf-simplify-empty-check-cheap-guard
branch
from
October 23, 2026 23:21
637cf24 to
cf00ba2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
SimplifyEmptyCheckOnEmptyArrayRector,refactor()invokedScopeFetcher::fetch($node)immediately at the start for everyBooleanNotandEmpty_node in the codebase. For boolean negations where the child expression is notempty(), and forempty()expressions whose argument is not a variable or property fetch, scope resolution was performed unnecessarily.Reproducer
Expected Behavior
SimplifyEmptyCheckOnEmptyArrayRectorshould perform cheap node checks and reject unsupported node shapes (such asBooleanNotwithoutEmpty_, or non-variable/property expressions) before fetching node scope.