Repository navigation
[removal] Remove @api annotations and dead/deprecated public API - #8794
Open
TomasVotruba wants to merge 3 commits into
Open
TomasVotruba wants to merge 3 commits into
TomasVotruba wants to merge 3 commits into
Conversation
TomasVotruba
force-pushed
the
tv-remove-api-annotations
branch
from
October 23, 2026 22:08
a395919 to
4304c03
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-remove-api-annotations
branch
8 times, most recently
from
October 24, 2026 09:37
55e06ba to
83b1f71
Compare
…omposerJsonAwareCodeSample, CategoryInfererInterface
TomasVotruba
force-pushed
the
tv-remove-api-annotations
branch
from
October 24, 2026 09:48
83b1f71 to
610f4c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drops the
@apidocblock annotations acrosssrc/andrules/, together with the dead public API they used to whitelist.Removed dead classes:
Rector\CodingStyle\ValueObject\ObjectMagicMethodsRector\PhpDocParser\ValueObject\AttributeKeyRector\RuleDoc\CodeSample\ComposerJsonAwareCodeSampleRector\RuleDoc\Contract\Category\CategoryInfererInterfaceRemoved unused public methods:
BetterNodeFinder::findFirstNonAnonymousClass()NodeFactory::createLocalMethodCall()RuleDefinition::setRuleFilePath(),getRuleFilePath(),getRuleShortClass(),isConfigurable()Removed unused constants on
SetListandBridgeItem.Why
@apionly existed to whitelist symbols from the shipmonk dead-code rules. These symbols are no longer used anywhere - core, rules or sibling extension packages - so the annotation hid genuinely dead code. Dropping it together with the dead symbols shrinks the public surface and lets the dead-code analysis cover the rest.Kept
A few symbols stay, with
@api, because they are consumed outside this repo:Set,SetInterfaceandRuleDefinition::getRuleClass()/setRuleClass()- used by the getrector.com websiteFixtureTempFileDumper,TestingParser- used by sibling package testsDecoupled
Larger removals that touched sibling packages were split into their own PRs and already merged:
PhpVersionFeatureconstants,UseNodesToAddCollector,GenericAnnotationToAttributeConverter,RectifiedAnalyzer+created_by_rule, and the deprecatedSetProvider/ComposerTriggeredSet/SetGroup/RuleCodeSamplePrinterInterfaceset.