Repository navigation
Replace symfony/console with entropy/entropy console framework - #8787
Draft
TomasVotruba wants to merge 5 commits into
Draft
TomasVotruba wants to merge 5 commits into
TomasVotruba wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
symfony/consolewith the lightweightentropy/entropyconsole framework, mirroring the approach in ecsphp/ecs-src#27.What changed
process,worker,list-rules,validate,custom-rule,setup-ci,composer-based) now implementEntropy\Console\Contract\CommandInterfaceinstead of extendingSymfony\Component\Console\Command\Command. CLI options are therun()method parameters.SymfonyStyleis replaced by an entropy-backedRectorStyle(overOutputPrinter,OutputColorizer,ProgressBar,ConsoleTable).bin/rector.phpbootsEntropy\Console\ConsoleApplicationand normalizes argv (decoration flags stripped, short options expanded, defaultprocesscommand injected).Configurationvalue object rather than from a SymfonyInputDefinition, soCommandFromReflectionFactoryis gone.RectorConfigsResolver,AutoloadFileParameterResolver,AdditionalAutoloader) no longer depends onArgvInput.symfony/consolemoved fromrequiretoreplace.Notes
invoke()in the deletedCommandFromReflectionFactory. With that gone, constructors of container-instantiated services are reported dead because shipmonk cannot see reflection-based instantiation. Added a singleshipmonk.deadMethodignore for::__construct, the same pattern used in ecs-src#27.