Repository navigation
Narrow blanket PHPStan ignores to real fixes - #8784
Closed
TomasVotruba wants to merge 1 commit into
Closed
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
Replace three repo-wide message-only ignores (class-string, list vs array, filterPolyfillPackages return) with real type fixes where provable, and path-scoped ignores for the genuine residual boundaries: - PolyfillPackagesProvider: honest array<int, string> return, not PolyfillPackage::* - ClassNameFromObjectTypeResolver: @return class-string|null - relax over-strict class-string params to string where only string-compared - array_values() for list vs array at the three provable sites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three blanket, message-only ignores in
phpstan.neonsuppressed errors repo-wide, masking any future real violation of the same shape. This replaces them with actual type fixes where the type is provable, and tight path-scoped ignores for the genuine residual boundaries.class-string, string given
ClassNameFromObjectTypeResolver::resolve()now declares@return class-string|null(it does resolve a class name), clearing the ReflectionResolver and one AstResolver call site.findDoctrineAnnotationsByClass()/findByAnnotationClass(): param relaxedclass-string->string; the body only string-compares annotation names, no reflection, soclass-stringwas over-strict.@apivalue-object ctors,getObjectClassNames()returningstring[],getName()strings, one test) are now path-scoped, not repo-wide.list vs array
array_values()at the three provable sites (SplitGroupedClassConstantsRector, AddReturnDocblockForCommonObjectDenominatorRector, RectorRegistry).filterPolyfillPackages return
symfony/polyfill-*package name but claimedarray<int, PolyfillPackage::*>. Types corrected toarray<int, string>across the method, property andprovide(); only consumer is a strictin_array.Net: 3 repo-wide mutes -> real fixes plus narrowly scoped residuals, so new violations elsewhere are caught again.
Note: the
symplify.commandHasAsCommandAttributeerrors onsrc/Console/Command/*are pre-existing on main (from the phpstan-rules bump), unrelated to this PR.