Repository navigation
[TypeDeclarationDocblocks] Keep native @param/@var/@return description on MergePhpstanDocTagIntoNativeRector - #8781
Merged
Merged
Conversation
…n on MergePhpstanDocTagIntoNativeRector
Member
Author
|
@TomasVotruba ready 👍 |
Member
|
Looks great |
samsonasik
commented
Oct 23, 2026
Comment on lines
+40
to
+41
| * @param string|list<string|null>|null $excludePattern Optional regex; classes matching this are excluded | ||
| * from the layer even when $pattern matches. |
Member
Author
There was a problem hiding this comment.
I just checked that on phpcs, multilines description on @param will got notice:
Squiz.Commenting.FunctionComment.MissingParamNameI am thinking when the tag is multilines, it should be skipped instead?
Member
There was a problem hiding this comment.
Maybe inline to a single-line comment? It might be hard to indent it exactly as before.
Member
Author
There was a problem hiding this comment.
that's will make another error, eg: more than 120 chars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9938
Do not remove existing description.