Repository navigation
[Transform] Deprecate StringToClassConstantRector as niche, never used and needs context - #8779
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
tv-deprecate-string-to-class-constant
branch
from
October 22, 2026 20:26
656a0a3 to
d7d5db3
Compare
…d and needs context
TomasVotruba
force-pushed
the
tv-deprecate-string-to-class-constant
branch
from
October 22, 2026 20:43
d7d5db3 to
5f887b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule is too niche, never used in practice and needs project-specific context to configure. It is not part of any rector-src set.
Following the deprecation pattern: marks the rule
@deprecated+DeprecatedInterface, guts the body to throw, removes its tests, drops its now-unmatchedrector.registerRectorignore from phpstan.neon. TheStringToClassConstantvalue object stays (marked@api) so existing user configs keep parsing.Write a custom rule for the exact project case instead.