Skip to content

feat: create rector to add names to boolean arguments#7944

Merged
TomasVotruba merged 1 commit into
rectorphp:mainfrom
calebdw:calebdw/push-muvroqtpsztq
May 16, 2026
Merged

feat: create rector to add names to boolean arguments#7944
TomasVotruba merged 1 commit into
rectorphp:mainfrom
calebdw:calebdw/push-muvroqtpsztq

Conversation

@calebdw
Copy link
Copy Markdown
Contributor

@calebdw calebdw commented Mar 29, 2026

Hello!

Please see https://x.com/VotrubaT/status/2037867835469238412 for context.

This adds names to boolean call-site arguments---this increases code quality by making it clear what the value being passed is for:

-in_array($value, $array, true);
+in_array($value, $array, strict: true);

Thanks!

@calebdw calebdw force-pushed the calebdw/push-muvroqtpsztq branch 2 times, most recently from 165c5cd to 3a3f880 Compare March 29, 2026 02:21
Comment thread src/Config/Level/CodeQualityLevel.php Outdated
Comment thread rules/CodeQuality/Rector/CallLike/NameBooleanOrNullArgumentRector.php Outdated
@calebdw calebdw force-pushed the calebdw/push-muvroqtpsztq branch from 3a3f880 to c45162e Compare March 30, 2026 01:29
@calebdw calebdw changed the title feat: create rector to add names to boolean and null arguments feat: create rector to add names to boolean arguments Mar 30, 2026
@calebdw calebdw force-pushed the calebdw/push-muvroqtpsztq branch 3 times, most recently from b427c6b to ad9d5d6 Compare March 31, 2026 16:27
@calebdw calebdw force-pushed the calebdw/push-muvroqtpsztq branch from ad9d5d6 to 6d31b0c Compare April 7, 2026 17:22
@TomasVotruba TomasVotruba merged commit 30a116f into rectorphp:main May 16, 2026
61 checks passed
@TomasVotruba
Copy link
Copy Markdown
Member

Let's ship this... Thank you 💪

@calebdw calebdw deleted the calebdw/push-muvroqtpsztq branch May 16, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants