Skip to content

fix AssertIsTypeMethodCallRector crash on enum case argument #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
May 21, 2026
+24 −0
Merged

fix AssertIsTypeMethodCallRector crash on enum case argument #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...PHPUnit120/Rector/Class_/AssertIsTypeMethodCallRector/Fixture/skip_non_string_arg.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?php

// skip: non-string argument (enum case) should not crash

namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\Class_\AssertIsTypeMethodCallRector\Fixture;

use PHPUnit\Framework\TestCase;

enum SkipNonStringArgEnum
{
case ONE;
}

final class SkipNonStringArg extends TestCase
{
public function testMethod(): void
{
$this->assertThat([], $this->isType(SkipNonStringArgEnum::ONE));
}
}
4 changes: 4 additions & 0 deletions rules/PHPUnit120/Rector/Class_/AssertIsTypeMethodCallRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,10 @@ public function refactor(Node $node): Node|null
}

$argValue = $this->valueResolver->getValue($arg);
if (! is_string($argValue)) {
return null;
}

if (isset(self::IS_TYPE_VALUE_TO_METHOD[$argValue])) {
if ($node instanceof MethodCall) {
return new MethodCall($node->var, self::IS_TYPE_VALUE_TO_METHOD[$argValue]);
Expand Down
Loading