Repository navigation
Resolve $this->method() return type in typescope - #12
Merged
Merged
Conversation
inferValueType now reads the declared return type of a $this->method() call from the collected class subtree, so a value flowing out of a local method resolves to its type. Single native types only; a missing, union, or non-$this return stays unresolved, and a nullable return keeps its inner type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
typescopeso a value flowing out of a local method call resolves to the method's declared return type.inferValueTypegains anExprMethodCallcase: a$this->method()call resolves to that method's return type, soResolveType/ResolveValue/ResolveClassall follow it.Scope matches the existing resolver: single native types only. A missing return type, a union/intersection, or a call on anything but
$thisstays unresolved; a nullable return keeps its inner type (?User->User).Unblocks the "method call on a
$this->getUser()result" case for downstream consumers.