Repository navigation
Pin gopls modernize to v0.23.0 - #11
Merged
Merged
Conversation
gopls v0.24.0 (now @latest) requires Go 1.27 and dropped the cmd/modernize package path, breaking the analysis job on every run. Pin to v0.23.0, the newest release that still ships the command; it reports no findings on the checked packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
analysisjob runsgopls modernize@latest. gopls v0.24.0 (now@latest) requires Go 1.27 and no longer ships thecmd/modernizepackage path, so the step fails on every run regardless of the change:Pin to v0.23.0, the newest release that still ships the command. It reports no findings on
./pkg/...and./internal/position/..., so this is a workflow-only fix with no code changes.