confirm: drop in-flight below lookup-wave drain+fence snapshot - #277
Merged
Conversation
Lookup notes drain_and_fence_hi before TipOnly and rides it on the last load batch of the wave. After that batch finishes its in-flight read, load drops layers with max_height below the snapshot so TipOnly-covered heights leave RAM without waiting on lookup_started_hi. Co-authored-by: Cursor <cursoragent@cursor.com>
rearden-grok Bot
added a commit
that referenced
this pull request
Aug 26, 2026
Owner docs and ibd: perf drop union=/keep=. Bind order is same-batch → in-flight → skeleton → Corrupt. In-flight prune stays the lookup-wave drain+fence snapshot on the last load batch (#277). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 26, 2026
RandyMcMillan
pushed a commit
to RandyMcMillan/rbitcoin
that referenced
this pull request
Aug 27, 2026
Replace InFlightLog/Layer/View with one HashMap (txid→fk, fk→CreatePin) plus a height index. prune_below_height still drops strictly below the reardencode#277 drain+fence snapshot; equality keeps because that height may be a partial drain. Snapshot isolation is gone: load notes after stamp. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drain_and_fence_hibefore each wave's TipOnly read and puts that height on the last load batch of the wave.max_heightbelow the snapshot (equality keeps). Unmarked earlier batches of the same wave do not prune.until = lookup_started_hilayer stamp /prune_if_drain_fencepath. Intended to land before store: load-batch parent skeleton; drop LiveUnion #275 for additional testing.Test plan
cargo test -p rbitcoin-query --lib -- in_flight inflight_binds leftover_tiponly prune_belowcargo test -p rbitcoin-consensus -- taken_hi_tracks stamp_uses_inflightcargo test -p rbitcoin-net -- last_sent_load_batch marked_load_batch prune_inflight confirm_engine_pinsfmt/deny/clippy/ast-grep/test/windows/macos/multinode/coverage)Made with Cursor