confirm: in-flight keep-until; drop RecentCreates and PipelineParentStore - #269
Merged
Conversation
Drain+fence is enough for TipOnly identity, not for CreatePin outs. Pin layers now wait for class_a_hi >= until frozen at write (lookup_started_hi.max(hi)), the RecentCreates drop horizon. Co-authored-by: Cursor <cursoragent@cursor.com>
CreatePin outs stay on InFlightView through write keep-until, so stamp no longer walks a second identity ring. Leftover after drain+fence is TipOnly. Co-authored-by: Cursor <cursoragent@cursor.com>
In-flight keep-until already holds CreatePin outs past Class A, so write no longer clones a second identity ring. Direct connect stamps idx only. Co-authored-by: Cursor <cursoragent@cursor.com>
In-flight keep-until is the only RAM create-outs chain past Class A. Stamp already walks InFlightView; write no longer published a second layer list. layer_chain CAS helpers were RecentCreates-only. Co-authored-by: Cursor <cursoragent@cursor.com>
Production IBD already passed None; tip-follow is one-shot. BatchParents stays batch-local Arcs. Cross-batch Weak adopt/publish is gone. Co-authored-by: Cursor <cursoragent@cursor.com>
Stamp order is in-flight → live_union → TipOnly. Pin layers wait for write-frozen until. PipelineParentStore is gone. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
class_a_hi >= until, withuntil = lookup_started_hi.max(hi)frozen at write (Query::stamp_create_keep_until→ load prunetake_create_keep_until). Stamp walksInFlightView(then live_union, then TipOnly). Drain+fence stays required: at tip-followuntil ≈ hi, sotx.headdrain can still be in flight when the height condition would otherwise fire.plan=None) still drop at drain+fence (untilunset + empty outs).PipelineParentStore: IBD never turned it on.BatchParentsstays batch-local. Weak registry /with_store/adopt_from_store/publish_to_store/WireLoadPipeline.parent_storeare gone.ibd: sizesrecent=/pstore=stay 0. Pin material remains pipeline-local (batch_pin/BatchParents).Test plan
rbitcoin-queryin-flight keep-until / stamp;rbitcoin-consensuswrite/pin; hub no longer constructs a parent store)fmt,deny,clippy,ast-grep,test,windows,macos,multinode,coverageMade with Cursor