store: replace undersized header.head instead of zeroing it - #268
Merged
Conversation
Open-grow read occupied slots, unlink the OA file, and create a new one at the target size. A crash mid-grow is a missing header.head (reindex), not a silent empty live table. .mlt is kept. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
H2: open-grow of an undersized single-gen
header.headused tozero_rangethe live OA file. A crash between zero and reinsert left an empty table that the next open treated as valid (silent index wipe).Open now reads occupied slots, unlinks the OA file, and creates a new one at the create target (
.mltkept). Crash after unlink is a missingheader.head(reindex), not a punched live file.Test plan
cargo test -p rbitcoin-store rewrite_to_slots_replaces_file_keeps_keyscargo test -p rbitcoin-store header_head_open_grows_undersized_single_gencargo test -p rbitcoin-store header_head_rollsMade with Cursor