store: fix Windows/Darwin --release store-test compile - #130
Merged
Conversation
Windows/Darwin smoke runs cargo test --release -p rbitcoin-store --lib, which compiles the whole test crate without debug_assertions. take_raw_clone_n was debug-only, so the has_raw clone-count test failed to compile. Gate the meter with cfg(any(test, debug_assertions)) so production release binaries stay clean.
rearden-grok
Bot
added
the
static-binaries
load_leftover_disconnected_parent_is_not_tipthenany already pins the unresolved error string. last_union_miss / last_plan_batch are process-global and flake under cargo test --workspace (CI test job on #130). Keep the error-string contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Master Windows/macOS smoke (
windows.yml/macos.ymlat394aba3d, after #129) failed compilingrbitcoin-storetestsin
--release:Those jobs run
cargo test --release -p rbitcoin-store --lib -- file::advise_tests::scripthash_body_create_open_roundtrip,which still typechecks the whole test crate.
take_raw_clone_nwascfg(debug_assertions)only.Not the #127 toy delete — it is the BQ raw-clone meter vs native
--releasesmoke.Change
Meter +
note_raw_clone+ crate re-export arecfg(any(test, debug_assertions)). Production--releasenodebuilds still omit the atomic.
Verify
cargo test --release -p rbitcoin-store --lib -- file::advise_tests::scripthash_body_create_open_roundtripfailed to compile.raw_payload_clones_one_has_raw_does_notpass in--releaseand debug.Please add label
static-binariesso windows/macos smoke run on this PR.