Clarify that server errors handled by Suspense are still reported#8534
Open
rohan4naik wants to merge 1 commit into
Open
Clarify that server errors handled by Suspense are still reported#8534rohan4naik wants to merge 1 commit into
rohan4naik wants to merge 1 commit into
Conversation
The 'Providing a fallback for server errors and client-only content' section stated React would not surface a server error when the client render succeeds. In practice React still reports it via onRecoverableError and logs recoverable error reactjs#419 to the console. Correct the wording and add a note about the opt-out caveat. Fixes reactjs#8497
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8497.
The "Providing a fallback for server errors and client-only content" section currently states:
This is misleading. Even when the client render succeeds, React still reports the error thrown on the server: it calls
onRecoverableErrorand logs recoverable error #419 to the console (in both dev and prod). As the issue notes, there is no documented way to distinguish an intentional server opt-out from a genuine error.Changes
onRecoverableErrorand logged to the console.<Note>under the opt-out example explaining the recoverable-error behavior and suggesting throwing a recognizable error that can be filtered in anonRecoverableErrorhandler.Docs-only change.
prettier --checkpasses.