Repository navigation
Support Babel 8 dependency overrides - #1103
Merged
Merged
Conversation
✅ Deploy Preview for react-docgen ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 02f48c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Stanzilla
marked this pull request as ready for review
July 14, 2026 09:15
3 of 7 tasks
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Stanzilla
force-pushed
the
b.staneck/babel-8-support
branch
from
October 30, 2026 11:02
ac9e94e to
66b8792
Compare
Contributor
Author
|
@danez friendly ping |
Keep the 8.x dependency versions, Node.js support, release configuration, and backported fixes while retaining the Babel 7/8 runtime compatibility changes. Exclude Node.js 20 only from Babel 8 jobs and keep the Babel 8 minimum-version check. Ignore age-dependent Browserslist warnings in CLI integration fixtures so stderr checks remain stable with the pinned browser data. Validated library and CLI builds, full lint, and coverage tests with both Babel 7 and Babel 8 runtimes on Node.js 24.22.0.
Collaborator
|
Sorry it took a while. I wasn't sure if i want to merge this, because for the next major i did refactor a lot of stuff, but it still makes sense to realese this now. |
Contributor
Author
no worries and thanks for the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Babel 8 dependency overrides fail because react-docgen uses removed parser options and path APIs, and reads TypeScript AST fields that changed in Babel 8.
Use the synchronous config API, preserve Babel 7 parser defaults, replace removed path checks, and support both AST shapes for generic props, inherited interfaces, function types, and mapped types.
Run all library and CLI tests in separate Babel 7 and Babel 8 CI jobs. The Babel 8 jobs replace core, traverse, and types, so CLI subprocesses use Babel 8 too. Keep all jobs and both test suites running when a test fails. Use Babel 8's minimum supported Node.js version on the Node 22 job.
The declared Babel 7 dependency ranges remain unchanged. Packages build against those declared types before the runtime compatibility tests. Contributor instructions include the Babel 8 reproduction commands.
Validation
On macOS with Node.js 24.20.0:
pnpm buildandpnpm lintpass.Closes #1102