Repository navigation
enhance(website): Give the dark playground preview a slate frame - #4253
Conversation
The dark Live Preview used a neutral grey body and a lighter grey header beside the indigo editor. It now takes the editor's hue a half step above the code, its header matches the editor tab bar, and fields and plain buttons sit in the code color with indigo borders. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PRuhAftAGskjoHVcigUFk
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Staff engineer (Cursor agent): LGTM at 80b441a. Non-blocking, nothing here needs to change in this PR. Good call retheming through the tokens the base rules already read ( FOLLOW_UP (after merge, only if it looks off): the board demo isn't covered by the pages you checked. |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PRuhAftAGskjoHVcigUFk
|
Board demo: confirmed. The RestEndpoint kanban preview showed neutral near-black columns and cards on the indigo body, so I folded the fix into this PR in 190e323. In dark mode the column is now a well in the code color and the cards are lifted to Literals: not changing this here. The hue-229 shades already live in the dark container's Generated by Claude Code |
The emoji rendered differently on every OS and was the only full-color glyph in the playground chrome. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PRuhAftAGskjoHVcigUFk
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4253 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 166 166
Lines 3166 3166
Branches 626 626
=======================================
Hits 3106 3106
Misses 18 18
Partials 42 42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fields and board columns already read --ifm-color-emphasis-100, so one token replaces two selector overrides. The live dot is now a pseudo-element. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PRuhAftAGskjoHVcigUFk
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PRuhAftAGskjoHVcigUFk
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PRuhAftAGskjoHVcigUFk
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PRuhAftAGskjoHVcigUFk
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a44ddef952
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PRuhAftAGskjoHVcigUFk
Requested by Nathaniel · project thread
Motivation
In dark mode, the playground's Live Preview looked off next to the editor. Its body was a warm neutral grey (
rgba(255,255,255,.1)over the page), and its header and Store rail were a lighter neutral grey, all beside the indigo editor. Two color families met at the seam, and the header was the brightest thing in the frame. Text fields sat in a neutral fill with a black label chip, plain buttons like "Load more" used the page's near-black, and the kanban demo showed near-black cards. The 🔴 emoji in the header also rendered differently on every OS.Solution
All changes are in
Playground/styles.module.cssandPreviewWrapper.tsx. Everything except the dot is dark-mode only.--pg-bar/--pg-tab-hover-bgoverride now applies to the whole (non-endpoint) playground, not just the editor column. The Live Preview header and the Store rail share the editor's tab-bar color, so the top row reads as one band. This holds in both the homepage layout (two tab layers) and the docs layout (one layer).hsl(229 9% 21%). The code background and the active tab (which matches it) keep their existing color, shared with light mode.hsl(229 7% 19%), wells a step below it athsl(229 7% 15%), and board cardshsl(229 7% 22%). Field borders arehsl(229 5% 48%), which keeps 3:1 contrast against both the well and the body.--ifm-background-surface-color,--ifm-color-emphasis-100and--ifm-color-emphasis-400. Hover and focus borders keep working unchanged, and the board demo's columns follow the same token. The floating label blends into both the preview and the field.design-system.cssis untouched, so this doesn't collide with fix(website): Keep the new-todo text field next to its checkbox #4252's small-field hover/focus styling.I checked a local dev build at 1280–1440px and 375px, in light and dark, at rest and focused. Pages checked: the homepage,
/docs/getting-started/data-dependency,/docs/getting-started/mutations, and/rest/api/RestEndpoint(board demo). EndpointPlayground is excluded and unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_017PRuhAftAGskjoHVcigUFk