Skip to content

internal: Regenerate playground editor types for set() row types - #4190

Merged
ntucker merged 1 commit into
masterfrom
claude/project-thread-orngyp
Oct 5, 2026
Merged

ntucker merged 1 commit into
masterfrom
claude/project-thread-orngyp

Conversation

@ntucker

@ntucker ntucker commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Requested by Nathaniel · project thread

Before: master fails the editor-types check because #4179 changed set() row types after #4189 added the check, so the committed playground core.d.ts was stale. Every PR touching packages inherits the failure.

After: the playground's @data-client/core.d.ts matches master's built types, and the check passes.

How: ran yarn copy:websitetypes on latest master and committed only the regenerated output. #4181 carries the same regeneration; whichever lands first wins.

🤖 Generated with Claude Code

https://claude.ai/code/session_01N2JUxvTqcHCdBX8Xi1nQq6


Generated by Claude Code


Note

Low Risk
Generated declaration-only sync for the docs playground; no runtime or package logic changes in this PR.

Overview
Refreshes the Playground’s committed @data-client/core.d.ts so it matches the current package build and the editor-types CI check passes again (stale after upstream set() input typing changed).

The diff is limited to SetRow / SetValue helpers for Controller.set(): it drops the old FieldKeys, MemberField, and SetItem layering and wires SetManyValue and SetInput through the simplified, distributive SetRow (union rows keyed by discriminators like type). No application runtime code changes—only regenerated Monaco/editor declarations.

Reviewed by Cursor Bugbot for commit 1d56b34. Bugbot is set up for automated code reviews on this repo. Configure here.

#4179 changed set() row types after #4189 added the editor-types
check, so master's committed core.d.ts was stale.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N2JUxvTqcHCdBX8Xi1nQq6
@vercel

vercel Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs-site Ready Ready Preview Oct 5, 2026 6:10pm UTC

Request Review

@ntucker ntucker self-assigned this Oct 5, 2026
@changeset-bot

changeset-bot Bot commented Oct 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1d56b34

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.09%. Comparing base (10e15cc) to head (1d56b34).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4190   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         165      165           
  Lines        3143     3143           
  Branches      625      625           
=======================================
  Hits         3083     3083           
  Misses         18       18           
  Partials       42       42           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntucker
ntucker merged commit 97b3016 into master Oct 5, 2026
25 checks passed
@ntucker
ntucker deleted the claude/project-thread-orngyp branch October 5, 2026 18:14

This branch was successfully deployed

1 active deployment
Preview — 1d56b34f Deployed Oct 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants