Fix testLoggerLeak by replacing Kotlin SAM lambda with anonymous object#1977
Closed
ellemac123 wants to merge 1 commit into
Closed
Fix testLoggerLeak by replacing Kotlin SAM lambda with anonymous object#1977ellemac123 wants to merge 1 commit into
ellemac123 wants to merge 1 commit into
Conversation
Summary:
Yoga test is failing after migration from java to kotlin due to the `testLoggerLeak` failing. The test creates a no-op `YogaLogger`, sets+unsets it on a config, drops all references, then asserts that a `WeakReference` to the logger gets cleared by GC. The Kotlin SAM lambda form (`YogaLogger { level, message -> }`) ends up with an implicit `this$0` capture of the enclosing test instance, so the logger never becomes weakly reachable and the test fails after 50 GC attempts.
Fix:
Replacing the SAM lambda with an explicit anonymous object expression to match what the Java version was doing.
Reviewed By: cortinico
Differential Revision: D108765169
|
@ellemac123 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108765169. |
cortinico
approved these changes
Jun 17, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in ef2efc5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Yoga test is failing after migration from java to kotlin due to the
testLoggerLeakfailing. The test creates a no-opYogaLogger, sets+unsets it on a config, drops all references, then asserts that aWeakReferenceto the logger gets cleared by GC. The Kotlin SAM lambda form (YogaLogger { level, message -> }) ends up with an implicitthis$0capture of the enclosing test instance, so the logger never becomes weakly reachable and the test fails after 50 GC attempts.Fix:
Replacing the SAM lambda with an explicit anonymous object expression to match what the Java version was doing.
Reviewed By: cortinico
Differential Revision: D108765169