Skip to content

Disable single-op batching under C++ native animated, otherwise enable by default (#57316) #57316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zeyap wants to merge 1 commit into from
+5 −4
Closed

Disable single-op batching under C++ native animated, otherwise enable by default (#57316) #57316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,7 +993,7 @@ const definitions: FeatureFlagDefinitions = {
ossReleaseStage: 'none',
},
animatedShouldUseSingleOp: {
defaultValue: false,
defaultValue: true,
metadata: {
dateAdded: '2024-02-05',
description:
Expand Down
3 changes: 2 additions & 1 deletion packages/react-native/src/private/animated/NativeAnimatedHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ const singleOpQueue: Array<unknown> = [];
const isSingleOpBatching =
Platform.OS === 'android' &&
NativeAnimatedModule?.queueAndExecuteBatchedOperations != null &&
ReactNativeFeatureFlags.animatedShouldUseSingleOp();
ReactNativeFeatureFlags.animatedShouldUseSingleOp() &&
!ReactNativeFeatureFlags.cxxNativeAnimatedEnabled();
let flushQueueImmediate = null;

const eventListenerGetValueCallbacks: {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<c9804d0743d9a9d905193cb02816da46>>
* @generated SignedSource<<f44477b5f5a4f7030798a61694d0332a>>
* @flow strict
* @noformat
*/
Expand Down Expand Up @@ -164,7 +164,7 @@ export const animatedShouldSyncValueBeforeStartCallback: Getter<boolean> = creat
/**
* Enables an experimental mega-operation for Animated.js that replaces many calls to native with a single call into native, to reduce JSI/JNI traffic.
*/
export const animatedShouldUseSingleOp: Getter<boolean> = createJavaScriptFlagGetter('animatedShouldUseSingleOp', false);
export const animatedShouldUseSingleOp: Getter<boolean> = createJavaScriptFlagGetter('animatedShouldUseSingleOp', true);

/**
* Use the deferred cell render update mechanism for focus change in FlatList.
Expand Down
Loading