Bump Maestro CI version to 2.6.1 for rn-tester e2e#57307
Closed
Abbondanzo wants to merge 1 commit into
Closed
Conversation
Summary:
Bumps `MAESTRO_VERSION` from `1.40.0` to `2.6.1` so we can use the new the visual-regression `assertScreenshot` command.
The two Maestro 2.0.0 breaking changes are already satisfied: JDK 17 is set up in both actions (`actions/setup-java@v5`), and the flows use only plain `${...}` variable interpolation rather than the JS scripting affected by the Rhino -> GraalJS engine swap.
Changelog: [Internal]
Differential Revision: D109359976
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109359976. |
|
This pull request has been merged in dc4d5e8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Bumps
MAESTRO_VERSIONfrom1.40.0to2.6.1so we can use the new the visual-regressionassertScreenshotcommand.The two Maestro 2.0.0 breaking changes are already satisfied: JDK 17 is set up in both actions (
actions/setup-java@v5), and the flows use only plain${...}variable interpolation rather than the JS scripting affected by the Rhino -> GraalJS engine swap.Changelog: [Internal]
Differential Revision: D109359976