Replace abort-controller that has no update 7 years with React Native fork#57230
Open
retyui wants to merge 2 commits into
Open
Replace abort-controller that has no update 7 years with React Native fork#57230retyui wants to merge 2 commits into
abort-controller that has no update 7 years with React Native fork#57230retyui wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
…AbortSignal.timeout(time)`
retyui
force-pushed
the
feat/retyui/abort-api
branch
from
c73abf7 to
bc9cea8
Compare
facebook-github-tools
Bot
added
the
Shared with Meta
retyui
commented
Jun 16, 2026
| * Abort and signal to any observers that the associated activity is to be aborted. | ||
| */ | ||
| abort(): void; | ||
| abort(reason?: any): void; |
Contributor
Author
There was a problem hiding this comment.
forgot to add reason as prop!
retyui
commented
Jun 17, 2026
| abort: {enumerable: true}, | ||
| }); | ||
|
|
||
| if (typeof Symbol === 'function' && typeof Symbol.toStringTag === 'symbol') { |
Contributor
Author
There was a problem hiding this comment.
I think this if can be removed
retyui
commented
Jun 17, 2026
| // 'throwIfAborted', | ||
| // 'addEventListener', | ||
| // 'dispatchEvent', | ||
| // 'removeEventListener', |
Contributor
Author
There was a problem hiding this comment.
to be align with spec this methods need to be available in a loops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Issue: #55247
We had a similar situation with
promisepackage that wan't maintained for long time, so Hermes team simply forked it https://github.com/facebook/hermes/blob/adf76f44a5175455a43c984e7d792015ebc3be2a/lib/InternalJavaScript/01-Promise.js#L53 to fix impl. issues and add more featuresChanges:
abort-controller(andevent-target-shimas subdep.) packagesabort-controller/srcfiles to thepackages/react-native/src/private/webapis/dom/abort-api/folderAbortSignal.any(signals),AbortSignal.timeout(time),signal.throwIfAborted();event-target-shimhas duplicate logic frompackages/react-native/src/private/webapis/dom/events/EventTarget.jsChangelog:
[GENERAL] [CHANGED] - Replace
abort-controllerwith fork version from react-nativeTest Plan: