Set dotStyle and activeDotStyle per mark#425
Open
ibash wants to merge 1 commit intoreact-component:masterfrom
ibash:dot_styles
Open
Set dotStyle and activeDotStyle per mark#425ibash wants to merge 1 commit intoreact-component:masterfrom ibash:dot_styles
ibash wants to merge 1 commit intoreact-component:masterfrom
ibash:dot_styles
Conversation
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
==========================================
- Coverage 83.47% 83.26% -0.21%
==========================================
Files 10 10
Lines 478 484 +6
Branches 113 115 +2
==========================================
+ Hits 399 403 +4
- Misses 79 81 +2
Continue to review full report at Codecov.
|
Author
|
cc @yesmeck what do you think? |
Member
|
Rebase please. |
|
So sad that this simple PR never made it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206
This allows setting custom dot styling on a per mark basis. Tried to be as least-intrusive as possible, but let me know if you'd prefer a different approach.