SPIKE: Pushable/combine with 0 thresholds#327
Open
polizz wants to merge 2 commits intoreact-component:masterfrom
Open
SPIKE: Pushable/combine with 0 thresholds#327polizz wants to merge 2 commits intoreact-component:masterfrom
polizz wants to merge 2 commits intoreact-component:masterfrom
Conversation
Member
|
Rebase please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically a feature request with some POC code to get your thoughts.
We use your control in the Range mode with multiple initial default values. We like pushable, but prefer not to have the threshold between handles. In this way, we want to allow the handles to collide, so that the handles you run into, push when they are run into, not before. Thus, you would go from two (or more) values to a single value when you collide with the other handle.
From what I can tell from your implementation, the handles are simply visualizations of an underlying array of (presumed) unique values, so this test currently behaves as though it combines the handles and you cannot select the other handle again. Without another widget to split them or reset the control state, I'm guessing there is no way to go back to your previous multiple handles.