RDKEMW-24305: [nativescript]xuaHeartbeat Analytics Event Is Not Trigg…

[gurpreet319]

…ered During Playback

Reason for change: Added polyfills for timeout, setinterval
Test Procedure: Playback should be pass
Risks: low
Priority: P2

[Copilot]

🟡 Changes recommended

Correct the timer apply and bind implementations before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds timer polyfills to the linked JSDOM wrapper to support playback analytics callbacks.

Changes:

• Adds apply, call, and bind support for timer APIs.
• Exposes timer functions on window.
• Wraps clear-timer functions.

File summaries

File	Summary
src/jsc/modules/linkedjsdomwrapper.js	Adds timer polyfills, but apply mishandles array-like arguments and bind drops bound arguments.

Review details

Suppressed comments (2)

src/jsc/modules/linkedjsdomwrapper.js:213

• The same array-only assumption breaks setInterval.apply(this, arguments): arguments has no slice method, causing a TypeError instead of registering the interval. Use Array.prototype.slice.call(args, 2) here as well.

    var callbackArgs = args.slice(2);

src/jsc/modules/linkedjsdomwrapper.js:249

• This custom bind ignores the timer ID bound after thisArg, so clearInterval.bind(null, intervalId)() clears undefined and the interval continues running. Preserve and prepend the bound arguments before selecting the ID.

clearInterval.bind = function(thisArg) {
    return function(id) { return clearInterval(id); };
};

• Files reviewed: 1/1 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.