Skip to content

feat: remove upstreams/downstreams from UpsertEntity, unify edge API#251

Merged
ravisuhag merged 1 commit intomainfrom
feat/unify-edge-api
Apr 18, 2026
Merged

feat: remove upstreams/downstreams from UpsertEntity, unify edge API#251
ravisuhag merged 1 commit intomainfrom
feat/unify-edge-api

Conversation

@ravisuhag
Copy link
Copy Markdown
Member

All relationships including data lineage are now sent as edges via UpsertEdge. Remove UpsertWithEdges service method and the special handling that converted upstreams/downstreams arrays into lineage edges. Regenerate protos from updated proton that removes the upstreams/downstreams fields from UpsertEntityRequest.

Edge types are now descriptive:

  • derived_from: entity depends on target (view from table, dashboard from datasource)
  • generates: entity produces target (job writes to downstream)
  • owned_by, member_of, belongs_to, references, consumed_by

All relationships including data lineage are now sent as edges via
UpsertEdge. Remove UpsertWithEdges service method and the special
handling that converted upstreams/downstreams arrays into lineage
edges. Regenerate protos from updated proton that removes the
upstreams/downstreams fields from UpsertEntityRequest.

Edge types are now descriptive:
- derived_from: entity depends on target (view from table, dashboard
  from datasource)
- generates: entity produces target (job writes to downstream)
- owned_by, member_of, belongs_to, references, consumed_by
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
compass Ready Ready Preview, Comment Apr 18, 2026 3:34am

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 18, 2026

Warning

Rate limit exceeded

@ravisuhag has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 47 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 47 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 15675fa5-b468-4c39-85da-d866d6dacc8e

📥 Commits

Reviewing files that changed from the base of the PR and between e2eff14 and d3b7750.

⛔ Files ignored due to path filters (2)
  • gen/buf/validate/validate.pb.go is excluded by !**/*.pb.go, !**/gen/**
  • gen/raystack/compass/v1beta1/service.pb.go is excluded by !**/*.pb.go, !**/gen/**
📒 Files selected for processing (4)
  • Makefile
  • core/entity/service.go
  • core/entity/service_test.go
  • handler/entity.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ravisuhag ravisuhag merged commit e3e0670 into main Apr 18, 2026
5 checks passed
@ravisuhag ravisuhag deleted the feat/unify-edge-api branch April 18, 2026 03:34
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 24596007878

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage decreased (-0.1%) to 8.648%

Details

  • Coverage decreased (-0.1%) from the base build.
  • Patch coverage: 17 uncovered changes across 2 files (0 of 17 lines covered, 0.0%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
gen/buf/validate/validate.pb.go 16 0 0.0%
handler/entity.go 1 0 0.0%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
gen/buf/validate/validate.pb.go 1 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 9540
Covered Lines: 825
Line Coverage: 8.65%
Coverage Strength: 1.98 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants